Rumblings quest finished?

[carceris-magister]

Should the "Rumblings" quest for Stoutford in the current master branch be working, or is it still unfinished?

I got into the bed in the tavern, ended up in an underground chamber, killed the monster that attacked me, and got a demon heart. Looking at the JSON for the quest, I think I should be at quest progress 50 "After sleeping in Glasforn's bed, I woke up in a cave, and was attacked by a monster. I killed it, but I should go see Glasforn again." However, when I look at the quest progress for my character, it's still only at quest progress 30 "Glasforn, the owner of the tavern of Stoutford, admits..." I'm happy to keep trying to figure out a way out of the cave past the invisible force, but I just want to make sure it's even possible at this stage in the software development.

[rijackson741]

It's finished in the Stoutford tests branch.

[Zukero]

Yeah, but I just checked, and there's a regression. In conversationlist_stoutford.json, the dialogue with id "stoutford_lich_killed_0" has two requirements for its only reply, including a questProgress on "rumblings" step 50. This requirement lacks the "negate":"true" line.

[rijackson741]

You are right. I wonder when that happened.

[Zukero]

When ATCS borked your project a while back.
Github's blame UI is cool to figure that kind of stuff out.

[rijackson741]

Ah, yes. The big negation mess, and subsequent fix. I hope that didn't mess anything else up.