are you sure button

[Samuel]

There are 3 comments available. I don't know why you complain.

[Samuel]

Further hints:

• Looks like you need to add something in the "saveWorld" function to prevent saving and show a error message instead.
• With the function quickload you may determine the FileHeader including the player name of a saved slot.
• The current player name is hidden here: world.model.player.traits.name

[ejwessel]

There are 3 comments available. I don't know why you complain.

Lol 3 comments out of 200 lines of code haha

[ejwessel]

I suggest that we have a save confirmation every time we're saving a game instead of just over the names that differ. I find myself often saving the same game at points in which a quest might diverge with whom you might pick to join sides with. Does anybody second this?

[Samuel]

I suggest that we have a save confirmation every time we're saving a game instead of just over the names that differ. I find myself often saving the same game at points in which a quest might diverge with whom you might pick to join sides with. Does anybody second this?

IMO this would be annoying and we should make it an option if we include it.

However perhaps we should add a possibility to rename the player ingame (or when saving).
Along with the feature: ask for confirmation when saving to different playernames this would solve all problems.
One could save on several slots with different names like: "player_prim", "player_bw". And you would get an confirmation dialog in usefull cases.

What do you think how could the player name be changed in a good way?
Perhaps the edit box in the menu (the one that appears when you start a new game) should not disappear when you continue a game.
Or when long clicking on a savegame one could choose: "save with different playername on this slot".

[ejwessel]

IMO this would be annoying...

I agree, I only suggested it because nearly all games have a confirmation.

As for the rest of what you said I'm still thinking about what we could do.

[ejwessel]

Submitted new patch for this.
Checks on the onClick function in LoadSaveActivity and determines from there

[Samuel]

What did you implement? Only the name check?
Do you consider to do the change the name code too?
Otherwise I consider it. May I see your changes then?

[ejwessel]

What did you implement? Only the name check?
Do you consider to do the change the name code too?
Otherwise I consider it. May I see your changes then?

I just put a check if the names differ(only the name check). I dont think the change name is necessary. As much as I do have different games I do like to keep the same name and its not like I couldn't just save a new file; I don't have to save over any of my other files.
Changes should be in the repository already

[ejwessel]

One could save on several slots with different names like: "player_prim", "player_bw". And you would get an confirmation dialog in usefull cases.

Although if you want go ahead and do this, but I really didn't feel it was necessary. Maybe we should add a location along with the stats in the slot bar?