Page 1 of 2

A secret garden: clearing out monsters

Posted: Mon Apr 27, 2020 8:45 pm
by JaSP
In "A secret garden", log entry 55 and related events may be skipped; I think that this is a bug. I would fix it by activating a unique cave troll near the statue and adding this kill to the progress requirements.

Re: A secret garden: clearing out monsters

Posted: Mon Apr 27, 2020 9:50 pm
by Nut
I think it does what it should. This message isn't necessary, it only helps to check when you could stop killing trolls.
If you find out without the message, so much the better.
Thx for posting it though :)

Re: A secret garden: clearing out monsters

Posted: Mon Apr 27, 2020 10:05 pm
by JaSP
Log entry 60 does not make sense without the 55. What about the removed spawn areas?

Re: A secret garden: clearing out monsters

Posted: Mon Apr 27, 2020 10:37 pm
by rijackson741
You can't get 60 without first getting 55.

I'm not sure what your question is regarding the removed spawn areas.

Re: A secret garden: clearing out monsters

Posted: Mon Apr 27, 2020 11:05 pm
by JaSP
You can skip entry 55 because phrase caeda_root50_3 only requires the monster kills; entry 55 is not required.

Re: A secret garden: clearing out monsters

Posted: Mon Apr 27, 2020 11:26 pm
by rijackson741
But there is a script on the map that gives you 55 as soon as you have those monster kills. Arguably, since that is the case, the conversation requirements could have been simplified to just require 55, but the way it's written works.

Re: A secret garden: clearing out monsters

Posted: Mon Apr 27, 2020 11:45 pm
by JaSP
The script only works when entry 50 happened, but 60 did not.
You can reproduce this bug by killing the required monsters before you are asked to do so, thus you do not need to return to the cave.

Re: A secret garden: clearing out monsters

Posted: Tue Apr 28, 2020 12:13 am
by rijackson741
Yes. Good point.
Fortunately, easily fixed by making the conversation requirement 55, rather than monsters killed.

Mostly, anyway. If you kill the monsters first, then return to the cave, the script will trigger immediately. Which would seem a little odd, since you didn't kill any more monsters. I can't immediately think of a good way out of that though.

Re: A secret garden: clearing out monsters

Posted: Tue Apr 28, 2020 12:15 am
by Antison
JaSP,

I recommend you make the changes and make a pull request. The team will review it and decide whether to move forward with it or not

Re: A secret garden: clearing out monsters

Posted: Tue Apr 28, 2020 1:14 pm
by Gonk
JaSP wrote: Mon Apr 27, 2020 8:45 pm I would fix it [...]
Hello JaSP,

Thank you for looking for bugs. Like Antison said, we would be happy if you have interest in addressing them.

We have ATCS as our content editor and it doesn't require programming knowledge:
viewtopic.php?f=6&t=4806

But maybe you even have programming knowhow?

If you want to test it on your phone you can build it using android studio. We have guides for content generation and building:
viewtopic.php?f=6&t=4560
You will have to use android studio 2.2.3:
viewtopic.php?p=62800#p62800

I could also assist you if you are interested.