Page 3 of 3

Re: are you sure button

Posted: Mon Jul 25, 2011 3:20 am
by qasur
An interesting idea, but maybe this type of implementation would be to fine-tuned for players.

Re: are you sure button

Posted: Mon Jul 25, 2011 4:45 am
by Samuel
ejwessel wrote:
Samuel wrote:What did you implement? Only the name check?
Do you consider to do the change the name code too?
Otherwise I consider it. May I see your changes then?
I just put a check if the names differ(only the name check). I dont think the change name is necessary. As much as I do have different games I do like to keep the same name and its not like I couldn't just save a new file; I don't have to save over any of my other files.
Changes should be in the repository already :)
Yes, I saw the code. Nice work. You should have taken a translatable string instead of a hardcoded English one, but the rest looked good. (Oskar corrected it.)
IMO naming the different savegames is really needed if we extend from 4 to unlimited. Someone stated this also here. I like the idea there to not rename the player but the savegame itself. Would be more consistent.

Re: are you sure button

Posted: Tue Jul 26, 2011 12:53 am
by ejwessel
Samuel wrote: You should have taken a translatable string instead of a hardcoded English one
Didn't know there was a translatable string. I just thought I'd do it in english and the translators would do the rest =P Good to know!
Samuel wrote:IMO naming the different savegames is really needed if we extend from 4 to unlimited. Someone stated this also here. I like the idea there to not rename the player but the savegame itself. Would be more consistent.
Great Idea!

Re: are you sure button

Posted: Tue Jul 26, 2011 2:23 am
by qasur
BTW, thanks guys for getting this done. I think my looking around at the files still had me confused, as this code is not native to me. I think I'll just stick to coming up with ideas/items/quests/improvements and seeing if you guys can program it for me :)