Taunt & Combat Log

[Antison]

I vaguely remember running into this issue or similar one years ago when the skills were first introduced and if it is the same issue, I'm surprised it has not been fixed yet.

I'm not convinced that the Taunt skill works as advertised, and what looks to be a bug in the combat log makes it even more difficult to prove or disprove my belief that the Taunt skill doesn't work.

What I think is happening is the taunt entry is being logged into the combat log before the entry that says the NPC misses. I think it would be much clearer if these two actions were logged as one entry in the combat log.
I would also suggest adding the NPC's AP bar graph underneath its HP bar graph just like it does for the hero.

Screenshot_20181231-114634.png

Screenshot_20181231-112740.png

Screenshot_20181231-114055.png

[Antison]

After looking at the code this morning, I see the problem and will maybe have time tomorrow to fix it. But I need help getting the project compiling.

[Flaming]

Does taunt work as advertised?

[Nut]

My last hero had much fun with it, yes

[rijackson741]

Yes, sort of. It depends on what you assume. The attacker loses 2AP, but it does not say for how long. The answer is the remainder of the current round, which differs from an actor condition, which lasts for the remainder of the current round and the next round. So Taunt has no benefit for monsters that only get one attack per round. However, there are less than 40 monsters for which that is the case.

[Antison]

I've fixed this and there is a PR for it that Kevin has provided feedback and suggestions on. But as far as I'm concerned I did what I set out to do in fixing the log order. If This fix gets included in the next release then great